feat(amazonq): skip registering run command log file #5493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karanA-aws
changed the title
karanA-aws
force-pushed
the
main
branch
2 times, most recently
from
983f9b1 to
4fbd7bf
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...rc/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt
Fixed
Show fixed
Hide fixed
karanA-aws
force-pushed
the
main
branch
2 times, most recently
from
8ac0a97 to
dffd769
Compare
karanA-aws
force-pushed
the
main
branch
2 times, most recently
from
961d59d to
aca090b
Compare
...rc/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt
Fixed
Show fixed
Hide fixed
karanA-aws
force-pushed
the
main
branch
3 times, most recently
from
26185ba to
3e05b4e
Compare
neilk-aws
previously requested changes
Mar 31, 2025
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationStateTest.kt
Outdated
Show resolved
Hide resolved
rli
approved these changes
Apr 2, 2025
| val mutableNewFileContents = codeGenerationStreamResult.new_file_contents.toMutableMap() | ||
| val keysToRemove = mutableListOf<String>() | ||
| for (file in mutableNewFileContents.keys) { | ||
| if (file.endsWith(".amazonq/dev/run_command.log")) { |
There was a problem hiding this comment.
The path is a placeholder value and won't interact with filesystem.
Using const. Thanks.
Comment on lines
214
to
225
| val mutableNewFileContents = codeGenerationStreamResult.new_file_contents.toMutableMap() | ||
| val keysToRemove = mutableListOf<String>() | ||
| for (file in mutableNewFileContents.keys) { | ||
| if (file.endsWith(".amazonq/dev/run_command.log")) { | ||
| val contents: String = mutableNewFileContents[file].orEmpty() | ||
| logger.info(contents) { "Run command log: $contents" } | ||
| keysToRemove.add(file) | ||
| } | ||
| } | ||
| keysToRemove.forEach { key -> mutableNewFileContents.remove(key) } | ||
|
|
||
| val newFileInfo = registerNewFiles(newFileContents = mutableNewFileContents) |
There was a problem hiding this comment.
Suggested change
| val mutableNewFileContents = codeGenerationStreamResult.new_file_contents.toMutableMap() | |
| val keysToRemove = mutableListOf<String>() | |
| for (file in mutableNewFileContents.keys) { | |
| if (file.endsWith(".amazonq/dev/run_command.log")) { | |
| val contents: String = mutableNewFileContents[file].orEmpty() | |
| logger.info(contents) { "Run command log: $contents" } | |
| keysToRemove.add(file) | |
| } | |
| } | |
| keysToRemove.forEach { key -> mutableNewFileContents.remove(key) } | |
| val newFileInfo = registerNewFiles(newFileContents = mutableNewFileContents) | |
| val fileContents = codeGenerationStreamResult.new_file_contents.filterKeys { file -> | |
| if (file.endsWith(".amazonq/dev/run_command.log")) { | |
| val contents: String = mutableNewFileContents[file].orEmpty() | |
| logger.info(contents) { "Run command log: $contents" } | |
| true | |
| } else { | |
| false | |
| } | |
| } | |
| val newFileInfo = registerNewFiles(newFileContents = fileContents) |
?
karanA-aws
force-pushed
the
main
branch
3 times, most recently
from
0866120 to
0155aea
Compare
osdemah
approved these changes
Apr 4, 2025
neilk-aws
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem:
Users currently cannot access logs generated by the Agent when it executes user commands during code generation.
Solution:
The logs emitted by the Agent during user command execution will be accepted and written to the
logsin the user's local repository. This ensures that:Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.